4 replies to this topic

[JustJake]

Dear Devs,

I see what you're doing here with this forums stuff. I don't think your current tactic of sticking the whole forumin an iFrame is a very good solution for long-term maintainability. The version of IPboards you're using does lots dynamic element addition and resizing, and that causes the height of your iframe's body element to expand vertically a lot.

Here are the actions that I've found expand the (inner) page body:

• Quick-replying to a post
  
• Sending a message to a user
  
• activating or de-activating editor features and toolbars

There are also numerous other actions and links that are broken due to edge-cases in your hash-change function and link re-writer:

• the button to send a message to a user from thier profile
  
• the middle mouse button to open a link in a tab
  
• the back button

In general your "parse a hash-link using String#split" strategy is really brittle.

Here is my suggestion, based on the fact that your forum host system (community.playhawken.com) is totally separate from your webhost (www.playhawken.com):

• Configure IPboards so that the IPboards web-url-root is www.playhawken.com/forums. IE, the header tag that IPboards prints for the board CSS should be

  http://www.playhawken.com/forums/public/style_css/css_7/ipb_styles.css

• Configure NGINX on www.playhawken.com to reverse-proxy requests to www.playhawken.com/forums(.*) to point to community.playhawken.com/(1)

As long as you guys want to do crazy iframe stuff using URL-mapping in Javascript (http://www.playhawke....js_v=r11212012), you might as well use a well thought-out and bug free URI handling library to do it, like URI.js: http://medialize.github.com/URI.js/

Edited by JustJake, December 04 2012 - 06:40 PM.

[JustJake]

Here's a common bug that I get when browsing the forum: incorrect URL re-writing. I've got broken history state bugs and incorrect locations when refreshing.

Example: URL didn't update as I moved into the messages center.


Here's an example of when the body of the iframe extends beyond the height initially allocated for it:


This is the most regular bug I get: multiply nested iframes. The innermost one actually has content, but it's only 150px tall.

Edited by JustJake, December 04 2012 - 06:05 PM.

[JustJake]

As long as you guys want to do crazy iframe stuff using URL-mapping in Javascript (http://www.playhawke....js_v=r11212012), you might as well use a well thought-out and bug free URI handling library to do it, like URI.js: http://medialize.github.com/URI.js/

[JustJake]

Help, JustJake, I'm a user!

Trying to forum and finding your activities thwarted by bugs_

The old forum location still exists! You just can't use it if you have Javascript turned on, because it'll send you back here.

Here's the steps to use the old forum:

Firefox:

• Install NoScript, an extension that lets you block Javascript on specific web pages: http://noscript.net/
  
• Go to community.playhawken.com, click on the NoScript icon in your Firefox toolbar menu, and select "Forbid community.playhawken.com"
  
• Click on the NoScript icon and select "Allow Scripts Globally (dangerous)". This will restore your browser's normal operation, as by default all browsers load scripts.

Chrome:

• Go to chrome://settings/contentExceptions#javascript (copy-paste if the link doesn't work)
  
• In the text box, type "community.playhawken.com", without the quotes
  
• Choose "Block" from the dropdown.
  
• Click "Ok"

Boom. Lightning-speed static, bug-free forum experience.

[Necro]

use this website instead, for some reason all of the HTML is still there.

http://community.playhawken.com/